search

ykdojo / editdojo

(I'm no longer working on this - currently working on https://github.com/ykdojo/defaang)
https://www.csdojo.io/edit
MIT License
332 stars 98 forks source link

Added login, register, and forgot password views. #26

Closed cameronthecoder closed 5 years ago

cameronthecoder commented 5 years ago

I have added login, register, and forgot password views to the project which is in the accounts app. For some reason, I couldn't use the reverse function for the success_url in the URL patterns but that should be fine. Also, I added an include in the main URLs file so I wouldn't have to import all the URL paths. This is my first contribution to anything so I hope I did everything right 😃

ykdojo commented 5 years ago

Thanks! Actually, I'm thinking of limiting the initial signup process to signing up with Twitter only - so maybe I'll integrate this code once we're ready to have more than that! (sorry)

cameronthecoder commented 5 years ago

No problem! That's okay, no hard feelings. Thanks for looking it over :) Should I close this PR for now?

cameronthecoder commented 5 years ago

Also as a suggestion, you could use something like django-allauth for Twitter integration.

ykdojo commented 5 years ago

Hmm I would say let's keep it open for now for reference?

And thanks for the suggestion!

Actually, I was looking at this tutorial, and it suggests using social-auth-app-django. Any idea which one might be a better choice?

cameronthecoder commented 5 years ago

Okay, that's fine with me. I've only used django-allauth once for one of my projects but I would use social-auth-app-django because it looks like it's last commit was 7 days ago vs 28 days ago (maybe that does or doesn't matter to you) and that django-allauth was a bit tricky to install for me but it all comes down to your personal preference :)

ykdojo commented 5 years ago

Okay sounds good! Maybe I'll try following that tutorial (or another one) for social-auth-app-django and see how it goes. If it's too hard, then I'll look into django-allauth :)

cameronthecoder commented 5 years ago

Aright sounds good!

ykdojo commented 5 years ago

Closing this issue for now.