Update docker.sh to add a check for existing image before building

ykdojo / kaguya

A ChatGPT plugin that allows you to load and edit your local files in a controlled way, as well as run any Python, JavaScript, and bash script.

http://kaguya.ai/

MIT License

1.2k stars 192 forks source link

Update docker.sh to add a check for existing image before building #16

Closed tianlelyd closed 1 year ago

tianlelyd commented 1 year ago

Added a check to see if the Docker image already exists before building it. This is to optimize the script by avoiding unnecessary image builds, which can be time-consuming, and directly using the existing image if it's already available.

ykdojo commented 1 year ago

Actually the original one should be okay because Docker should be able to simply use the cached layers to create the image. So no extra storage should be consumed at every subsequent build after the first one

https://chat.openai.com/share/bb9fe10b-dbb6-4f65-83ab-9b22b92f5edb

tianlelyd commented 1 year ago

It is true that docker will use caching and will not consume too many resources, but because the process will be built every time, it will bring more waiting time to users! I would have tested about 4s longer, which would have been unnecessary

ykdojo commented 1 year ago

Interesting. What about when someone wants to develop Kaguya and change Dockerfile and things though?