ykdojo / kaguya

A ChatGPT plugin that allows you to load and edit your local files in a controlled way, as well as run any Python, JavaScript, and bash script.
http://kaguya.ai/
MIT License
1.2k stars 191 forks source link

Embed videos directly into Readme #23

Closed pushkaraj2007 closed 1 year ago

pushkaraj2007 commented 1 year ago

Changes I made:

ykdojo commented 1 year ago

Thank you for this! I added a few comments

pushkaraj2007 commented 1 year ago

Hey @ykdojo

I have Swapped the demo videos and also removed the extra line.

I'm not sure about the repetitiveness of the words you are talking about. Can you explain it a bit more?

Should we write it as:

Here is the first demo video of Kaguya: and Here is the second demo video of Kaguya:

ykdojo commented 1 year ago

It's not that big of a deal, but it's just that those two sentences have some repetitiveness, namely: "Here's the 1st/2nd demo video of Kaguya:"

pushkaraj2007 commented 1 year ago

@ykdojo

What if we only keep "Here are the demo videos of Kaguya:"

And show both of the videos?

ykdojo commented 1 year ago

That sounds good! Thank you.

On Wed, Jul 5, 2023 at 1:07 PM Pushkaraj Kulkarni @.***> wrote:

@ykdojo https://github.com/ykdojo

What if we only keep "Here are the demo videos of Kaguya:"

And show both of the videos?

— Reply to this email directly, view it on GitHub https://github.com/ykdojo/kaguya/pull/23#issuecomment-1621626952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2JQ45NIDUUCACX5PTEEDXOVKGNANCNFSM6AAAAAAZ54BRI4 . You are receiving this because you were mentioned.Message ID: @.***>

pushkaraj2007 commented 1 year ago

Let me do it, real quick!

pushkaraj2007 commented 1 year ago

I have made the changes. Can you please check it now?

ykdojo commented 1 year ago

Looks good! Thank you