Ignore SWT tracing function in trace builder and update tests.

ykjit / yk

yk packages

https://ykjit.github.io/yk/

Other

29 stars 7 forks source link

Ignore SWT tracing function in trace builder and update tests. #1331

Closed Pavel-Durov closed 1 month ago

Pavel-Durov commented 2 months ago

Changes

Ignore the tracing function yk_trace_basicblock in tracer builder.
Update ignored tests

Tests

Tested multiple times as:

YKB_TRACER=hwt cargo test

YKB_TRACER=hwt YKD_NEW_CODEGEN=1 cargo test

YKB_TRACER=swt cargo test

YKB_TRACER=hwt YKD_NEW_CODEGEN=1 cargo test

Notes

I did see simple_binop.c test failing one time with a warning: yk-warning: trace-compilation-aborted: Trace too long. But I don't think it's relevant to my changes in the PR.

ptersilie commented 2 months ago

There's a couple of ignored tests that just say "crashes with SWT". Are these all the same crashes or are they different? What's the plan for these tests? Do we want to fix them here, or will that be a follow up PR?

Btw, the llvm backend is dead, so you don't need to test with YKD_NEW_CODEGEN=1 anymore.

Pavel-Durov commented 2 months ago

There's a couple of ignored tests that just say "crashes with SWT". Are these all the same crashes or are they different? What's the plan for these tests? Do we want to fix them here, or will that be a follow up PR?

The purpose of this PR was to update the state of failing tests with SWT. The next steps will be to triage the failures and come up with a plan to fix them.

The "crashes with SWT" comment was just copied from another source, like this one. I can remove the FIXME comments or add them to all of the tests that are ignored for SWT. Any preference?

ltratt commented 1 month ago

@ptersilie Over to you.

ptersilie commented 1 month ago

Please squash.