ykjit / yk

yk packages
https://ykjit.github.io/yk/
Other
29 stars 7 forks source link

Unhandled control flow kinds in disassembly-based PT decoding. #883

Open vext01 opened 11 months ago

vext01 commented 11 months ago
Text (error at line 2418):                                                                                                                                                                         
   ...                                                                                                                                                                                             
   |thread '<unnamed>' panicked at hwtracer/src/pt/ykpt/mod.rs:627:22:                                                                                                                             
   |not yet implemented                                                                                                                                                                            
   |note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace                                                                                                                  
>> |fatal runtime error: failed to initiate panic, error 5                                                                                                                                         

Which is the default case when handling kinds of x86_64 instructions.

https://github.com/ykjit/yk/blob/928ad5c00633d8f4be415c295773778eea130627/hwtracer/src/pt/ykpt/mod.rs#L611

Looking at what's not covered, we have:

We should cover all of these anyway.

vext01 commented 11 months ago

https://github.com/ykjit/yk/pull/886 made this easier to diagnose next time this arises.