Creduce with cvice and single lua source compilation

ykjit / yklua

yk-enabled Lua interpreter

4 stars 4 forks source link

Creduce with cvice and single lua source compilation #77

Closed Pavel-Durov closed 11 months ago

Pavel-Durov commented 12 months ago

Add cvice scripts and onelua compilation support.

ltratt commented 12 months ago

I'm not totally certain if having this in the repo is a good idea, but let's go with it and see what we think after a while. At a minimum, we should put this in a directory called something like creduce so that the changes are a) localised to that directory b) don't show up as conflicts/changes if we diff this repo against "real" Lua. Does that make sense?

Pavel-Durov commented 12 months ago

ok, makes sense.

Pavel-Durov commented 12 months ago

@ltratt updated 👉 47e8902a25b755b78e4a4ce23dc511c3cb63573c

ltratt commented 12 months ago

I think we just need one of creduce/cvise.sh and creduce/cvise.example.sh?

Pavel-Durov commented 12 months ago

We need to build onelua.c source code first, only then we can run: cvise ./cvise.example.sh onelua.c, otherwise cvise exit with error:

Traceback (most recent call last):
  File "/usr/bin/cvise", line 299, in <module>
    test_manager = testing.TestManager(pass_statistic, args.interestingness_test, args.timeout,
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/cvise/utils/testing.py", line 158, in __init__
    self.check_file_permissions(test_case, [os.F_OK, os.R_OK, os.W_OK], InvalidTestCaseError)
  File "/usr/share/cvise/utils/testing.py", line 233, in check_file_permissions
    raise error(path, m)
cvise.utils.error.InvalidTestCaseError: The specified test case 'onelua.c' cannot be accessed!

ltratt commented 12 months ago

Ah, I see the confusion. Why don't we provide build_one_lua.sh (or a Makefile target) which just builds one.lua and then cvise.example.sh as the script that cvise itself runs?

Pavel-Durov commented 12 months ago

done 👉 32c646405a24e54d1c9cad981f244dac2749847b

ltratt commented 12 months ago

This looks good to me -- @nmdis1999 can you also have a look please?

nmdis1999 commented 11 months ago

This looks good to me -- @nmdis1999 can you also have a look please?

Sure. Added a comment.

Pavel-Durov commented 11 months ago

@nmdis1999 Where is your comment? I can't find it 😶

ltratt commented 11 months ago

Please squash.

Pavel-Durov commented 11 months ago

squashed 👉 92f464557e7905d82d3a4ad1d33b613a06ee5943

Pavel-Durov commented 11 months ago

CI failed :( I think we need to merge first this PR https://github.com/ykjit/yklua/pull/79