search

ykkunkels / ESIR_portal

Shiny app for the ESM Item Repository
2 stars 0 forks source link

Change all hardcoded object assignments to dynamic assignments #15

Closed ykkunkels closed 5 months ago

ykkunkels commented 9 months ago

Parts of the Repository code still include hardcode information (e.g., df[, 15:19]). This is a hinderance for Repository growth and change, so all hardcoded assignments should be made dynamic.

millapihlajamaki commented 7 months ago

I discussed this with Laura and think that I could take this on after the code style / linting is done?

ykkunkels commented 7 months ago

Sure, if you would like to tackle this issue, I'll assign you to it.

This issue might possibly be quickly solved; I don't think there's that much hardcoded information, but good to check it thoroughly nonetheless.

Another worthwhile issue might be: Navigate to an item by entering the item number #30, but only if you have time to spare.