search

ykkunkels / ESIR_portal

Shiny app for the ESM Item Repository
2 stars 0 forks source link

Missing IDs #35

Closed BenjaminKunc closed 3 weeks ago

BenjaminKunc commented 3 months ago

Some of the items in the Repository have no IDs.

Specifically, it regards all items from the following datasets:

Since the IDs are hardcoded in the server.R script on line 30: " df[, "item_ID"] <- 1:nrow(df) #fill the item_ID column", it would be good to find out why the IDs are missing in these datasets.

BenjaminKunc commented 3 weeks ago

Now the IDs are added during the submission process, and are no longer missing.

I wonder if it is necessary to keep the "df[, "item_ID"] <- 1:nrow(df)" code in the server script, since right now it seems to just rewrite the IDs every time the main file is accessed.

ykkunkels commented 3 weeks ago

Good that the submissio process now adds the ID's.

For now, we can keep the "df[, "item_ID"] <- 1:nrow(df)" code in the server script. It doesn't yet interfere and could catch manual errors.