yko / mojolicious-plugin-linkedcontent

Plugin to manage css and js
2 stars 2 forks source link

t/linked_content.t fails with newer Mojolicious #5

Open eserte opened 4 years ago

eserte commented 4 years ago

On my smokers:

Transaction already destroyed at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Mojolicious/Plugin/DefaultHelpers.pm line 175.
# Looks like your test exited with 2 just after 6.
t/linked_content.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 6/12 subtests 

Statistical analysis suggests that this failure happens with newer Mojolicious versions (theta=-1 means "bad"):

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    9070476980174826.00
[1='eq_5.32']        -0.0000          0.0000      -0.18
[2='eq_5.71']        -0.0000          0.0000      -0.24
[3='eq_5.72']         0.0000          0.0000       0.24
[4='eq_5.75']        -0.0000          0.0000      -0.44
[5='eq_5.79']        -0.0000          0.0000      -0.18
[6='eq_5.81']        -0.0000          0.0000      -0.36
[7='eq_6.03']        -0.0000          0.0000      -0.18
[8='eq_6.08']        -0.0000          0.0000      -0.71
[9='eq_6.11']         0.0000          0.0000       0.41
[10='eq_6.17']       -0.0000          0.0000      -0.21
[11='eq_6.27']        0.0000          0.0000       0.21
[12='eq_6.31']       -0.0000          0.0000      -0.18
[13='eq_6.32']       -0.0000          0.0000      -0.53
[14='eq_6.34']        0.0000          0.0000       0.36
[15='eq_6.36']        0.0000          0.0000       0.36
[16='eq_6.37']        0.0000          0.0000       1.07
[17='eq_6.38']        0.0000          0.0000       0.36
[18='eq_6.41']        0.0000          0.0000       0.36
[19='eq_6.57']        0.0000          0.0000       0.36
[20='eq_6.58']        0.0000          0.0000       0.21
[21='eq_6.60']       -0.0000          0.0000      -0.41
[22='eq_6.62']        0.0000          0.0000       0.22
[23='eq_6.66']        0.0000          0.0000       0.18
[24='eq_7.0']        -0.0000          0.0000      -0.45
[25='eq_7.03']        0.0000          0.0000       0.00
[26='eq_7.06']        0.0000          0.0000       0.18
[27='eq_7.07']        0.0000          0.0000       0.41
[28='eq_7.08']        0.0000          0.0000       1.23
[29='eq_7.09']       -0.0000          0.0000      -0.18
[30='eq_7.10']        0.0000          0.0000       0.89
[31='eq_7.12']       -0.0000          0.0000      -0.36
[32='eq_7.14']        0.0000          0.0000       0.21
[33='eq_7.21']       -0.0000          0.0000      -0.21
[34='eq_7.22']        0.0000          0.0000       0.00
[35='eq_7.26']       -0.0000          0.0000      -0.53
[36='eq_7.28']       -0.0000          0.0000      -0.18
[37='eq_7.30']       -0.0000          0.0000      -1.80
[38='eq_7.31']       -0.0000          0.0000      -1.31
[39='eq_7.33']       -0.0000          0.0000      -0.41
[40='eq_7.35']       -0.0000          0.0000      -0.82
[41='eq_7.36']        0.0000          0.0000       0.82
[42='eq_7.37']       -0.0000          0.0000      -0.36
[43='eq_7.41']       -0.0000          0.0000      -1.78
[44='eq_7.43']       -0.0000          0.0000      -0.82
[45='eq_7.44']        0.0000          0.0000       0.00
[46='eq_7.46']        0.0000          0.0000       2.33
[47='eq_7.48']       -0.0000          0.0000      -0.41
[48='eq_7.50']        0.0000          0.0000       0.00
[49='eq_7.54']        0.0000          0.0000       1.78
[50='eq_7.60']       -0.0000          0.0000      -1.23
[51='eq_7.61']       -0.0000          0.0000      -0.82
[52='eq_7.68']        0.0000          0.0000       0.36
[53='eq_7.69']       -0.0000          0.0000      -2.14
[54='eq_7.71']       -0.0000          0.0000      -1.84
[55='eq_7.75']        0.0000          0.0000       1.07
[56='eq_7.81']       -0.0000          0.0000      -1.78
[57='eq_7.83']        0.0000          0.0000       0.71
[58='eq_7.84']        0.0000          0.0000       0.00
[59='eq_8.0']        -0.0000          0.0000      -0.82
[60='eq_8.09']       -0.0000          0.0000      -0.82
[61='eq_8.11']       -0.0000          0.0000      -2.85
[62='eq_8.12']       -0.0000          0.0000      -0.82
[63='eq_8.14']        0.0000          0.0000       0.00
[64='eq_8.15']        0.0000          0.0000       0.87
[65='eq_8.16']       -0.0000          0.0000      -1.42
[66='eq_8.24']       -1.0000          0.0000    -7855263489273364.00
[67='eq_8.25']       -1.0000          0.0000    -8397629902770095.00
[68='eq_8.26']       -1.0000          0.0000    -8861932391377260.00

R^2= 1.000, N= 167, K= 69
****************************************************************
eserte commented 4 years ago

Here's a new analysis which shows that the last Mojolicious version which is not causing the test failure is 8.23:

...
[67='eq_8.17']       -0.0000          0.0000      -1.06
[68='eq_8.23']        0.0000          0.0000       0.65
[69='eq_8.24']       -1.0000          0.0000    -5845149741291434.00
[70='eq_8.25']       -1.0000          0.0000    -6363393038366716.00
[71='eq_8.26']       -1.0000          0.0000    -6646347264262104.00
...
EmilianoBruni commented 2 years ago

This is solved in my pull request #4