search

yktoo / indicator-sound-switcher

Sound input/output selector indicator for Linux
https://yktoo.com/en/software/sound-switcher-indicator/
GNU General Public License v3.0
367 stars 29 forks source link

Simple check if locale dir is available at the system #34

Closed avlach closed 7 years ago

avlach commented 7 years ago

I just installed on my system (Arch Linux w/ XFCE desktop environment). Installation fails since it cannot detect any locale directory so I had to add this simple check to proceed with the installation. Maybe this prevents some non Ubuntu users with similar configuration from installing the application. Thanks for your effort! Very useful app.

yktoo commented 7 years ago

Hmm, catching any exception is a rather crude solution to the issue. The locale dir is in the source tree, and it is rolled into the source tarball, so it should always be present.

How exactly did you install the app?

avlach commented 7 years ago

True, that was a heavy hand solution. I tried downloading the release file (.tar.gz) and also cloning master branch then following the install instructions (sudo python setup.py install). I couldn't find locale in either the tarfile or the repo folder so I assumed something has to do with my system.

yktoo commented 7 years ago

That's correct, locale is not in the source tree initially, it is generated by build_package. I will think how this is to be resolved properly. Will close the issue for now.

yktoo commented 7 years ago

I will add instructions on how to install from the repo.