yktoo / indicator-sound-switcher

Sound input/output selector indicator for Linux
https://yktoo.com/en/software/sound-switcher-indicator/
GNU General Public License v3.0
367 stars 29 forks source link

Crash when restarting Pulseaudio #45

Closed pabloab closed 5 years ago

pabloab commented 7 years ago

I was trying paprefs to output simultaneously when notice indicator-sound-switcher crash always I (kill and)restart Pulseaudio (pulseaudio -k). Using v2.1.1, Ubuntu 16.04 and pulseaudio 8.0.

yktoo commented 7 years ago

Well yes, SSI doesn't account for PulseAudio dying while it's running. For me, it actually shows a critical error CRI Context failed. I'm not sure it's a problem really, obviously a sound switcher cannot function without the sound server. Perhaps exiting after PA has gone offline would be more consistent.

pabloab commented 7 years ago

Maybe instead of crashing could handle/catch the situation, for example keep waiting to PA to come back (as usually happens after a pulseaudio -k). Also maybe could send a warning to notify-osd.

yktoo commented 7 years ago

I wholeheartedly agree that nothing should ever crash, but in my case there was no crash, just a log message with CRITICAL status. I'll think what can be done here.