search

ylabonte / ioBroker.procon-ip

Adapter for ProCon.IP swimming pool control unit. It is intended for integration with your ioBroker home automation eg. building logic that involves other devices or to be combined with voice assistants (Alexa, Siri, Google) to give water temperature info or switch relays.
MIT License
6 stars 3 forks source link

Please consider fixing issues detected by repository checker #105

Closed ioBroker-Bot closed 1 month ago

ioBroker-Bot commented 2 months ago

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter procon-ip for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.procon-ip

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

:thumbsup: No errors found

WARNINGS:

:thumbsup: No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck @iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users. Let's work together for the best user experience.

your ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Mon, 09 Sep 2024 00:00:27 GMT

ylabonte commented 1 month ago

@iobroker-bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

The following issues are new and have been added [W130] Many "common.news" found in io-package.json. Repositorybuilder will truncate at 7 news. Please remove old news.

RECHECK has been performed as requested.

ylabonte commented 1 month ago

@iobroker-bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

The following issues are not fixed and have been reopened [W523] "package-lock.json" not found in repo! Please remove from .gitignore!

RECHECK has been performed as requested.

ylabonte commented 1 month ago

Hi @mcm1957, I'm using yarn as package manager for this project. Is there a any way to mark the remaining issue/Warning as won't fix ,so that the bot stops complaining about?

mcm1957 commented 1 month ago

Sorry to say but at the monet it's not possible.

But I'm aware that some projects do not or cannot provide package-lock.json. So it's on my (long) list to look for a solution. At the moment I can only advise to ignroe the warning / issue. Hope that I get a solution in thenear future.

And MANY THANKS for fixing all the otehr stuff.

ylabonte commented 1 month ago

Thanks a lot for your quick reply! And also for your work, making it a lot easier to keep track of the conventions and requirements for ioBroker adapters. 👍

So I will leave this issue open and simply wait for the bot to update it.

ioBroker-Bot commented 1 month ago

Issue outdated due to RECREATE request. Follow up issue #114 has been created.
This issue will be closed.

your
ioBroker Check and Service Bot