search

yldio / styled-is

A flag utility for styled-components
Mozilla Public License 2.0
210 stars 8 forks source link

1.2.0 breaks styles #43

Closed beautyfree closed 5 years ago

beautyfree commented 5 years ago

This code: image

Produces this styles with v1.2.0: image

SaraVieira commented 5 years ago

Hey!

Can you please create a CodeSandbox so I can test and fix ?

mboudriga commented 5 years ago

I'll take a look at this, I think I know whats happening

SaraVieira commented 5 years ago

Oh! Thanks man !!

mboudriga commented 5 years ago

I'm unable to test that it works for your specific scenario, but this works for something similar I setup locally: https://github.com/yldio/styled-is/pull/44

SaraVieira commented 5 years ago

I published as 1.2.1, @beautyfree Can you try please?

mboudriga commented 5 years ago

@beautyfree did you get a chance to test this?

mboudriga commented 5 years ago

@SaraVieira Do we want to just close this since its been two weeks?

SaraVieira commented 5 years ago

Yap! Im gonna close it!

Thanks again for your help!