ylechelle / OpenIDFA

285 stars 49 forks source link

OpenIDFA on CocoaPods needs to be updated for arm64 #3

Closed jonalmeida closed 10 years ago

jonalmeida commented 10 years ago

In the 0.0.1 pod, the libOpenIDFA.a isn't built for 64bit devices. It might be best to expose the header and class files to the Pod so people can build their dependencies locally. This also benefits for those trying to build for iOS 6+ devices (32bit/64bit).

jonalmeida commented 10 years ago

For some reason the Podspec file has been removed. I'm not sure if that was intentional or not. Also is this still an active project?

jonalmeida commented 10 years ago

Worth mentioning that the reason this differs from #1 is because it would be easier to add OpenIDFA to static libraries via cocoapod.

UIApplication is also used, and static libraries don't add that in. Is there a way around it?

ylechelle commented 10 years ago

Hi John, The static library has been removed. Meanwhile, the source code has been added… Best, Yann

ylechelle commented 10 years ago

Podspec has been removed for the same reason.

jonalmeida commented 10 years ago

@ylechelle Thanks for the update. It might be best to remove the Pod from the Cocoapods as well and not just the podspec file in this repository.

Also, I want to implement OpenIDFA into my static library, would I be able to remove the UIApplication dependency here?

ylechelle commented 10 years ago

Indeed, need to look at the CocoaPods issue. To implement OpenIDFA in your own static library, make sure to add a prefix of your own to the class… to avoid conflict. Why would you want to remove the UIApplication dependency/method? It comes standard in UIKit… plus this part of the code is super important to make sure the OpenIDFA is very unique, and avoid unwanted collisions….

jonalmeida commented 10 years ago

Why not just add the two required headers into the class file though?

#import <UIKit/UIKit.h>
#import <UIKit/UIDevice.h>

UIKit.h for [UIApplication sharedApplication] and UIDevice for [[UIDevice currentDevice] systemVersion].