search

ylecuyer / envify

Colorify tabs with current env
https://addons.mozilla.org/en-US/firefox/addon/envify/
40 stars 5 forks source link

Does not work correctly with dark theme #11

Closed garrettw closed 6 years ago

garrettw commented 6 years ago

I am using Firefox Developer Edition with the built-in Dark theme, and on tabs that do not match a pattern, Envify sets the tab and toolbar color to white rather than the color actually defined in the theme. (The tab bar, however, stays dark.)

Furthermore, just disabling Envify does not fix the problem; I also have to restart Firefox for the Dark theme to fully take effect again.

etiennewan commented 6 years ago

This is related to #7 because we reset the theme, and the theme API behaviour is to reset to default not to the user's theme. It should be fixed at the same time #7 is closed.

tzikas97 commented 6 years ago

@garrettw You can check out my solution here.

garrettw commented 6 years ago

Not the worst idea, at least as a stop-gap.