search

ylecuyer / survey-gizmo-ruby

Gem to use the Survey Gizmo API
MIT License
23 stars 26 forks source link

Allow setting default locale for multi-language title #101

Closed apuntovanini closed 6 years ago

apuntovanini commented 6 years ago

Instead of hardcoded 'English', one can choose other locales to work from

jarthod commented 6 years ago

Looking nice, could you please add an example in the readme with a comment about the use of this option? Any feedback @apurvis ?

apurvis commented 6 years ago

Looks great to me just make sure to update the README before merging

apuntovanini commented 6 years ago

Thanks @jarthod @apurvis, I added a little comment into the Readme, just edit it in case it isn't clear enough

apurvis commented 6 years ago

Lgtm Fwiw I'm going to be generally less active maintaining this gem since I am no longer working for anyone using surveygizmo. Still happy to take a look though

jarthod commented 6 years ago

Thanks for your contribution, I've merged this and released 6.5.1

apurvis commented 6 years ago

not a huge deal but should be 6.6.0... https://semver.org

On Mon, Dec 18, 2017 at 3:10 AM, Adrien Jarthon notifications@github.com wrote:

Thanks for your contribution, I've merged this and released 6.5.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jarthod/survey-gizmo-ruby/pull/101#issuecomment-352353772, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOJDnlqVMtb4VmS3QPXyMIaKpgbfsqVks5tBh3_gaJpZM4Q5zEb .

jarthod commented 6 years ago

Good point, I've updated to 6.6.0