yleeyilin / pe

0 stars 0 forks source link

ADD Feature does not account for special characters in names #2

Open yleeyilin opened 2 months ago

yleeyilin commented 2 months ago

Steps to reproduce:

Expected:

Actual:

Screenshots:

image.png

This is problematic as there may be some foreigners, especially from different countries with such special names. You can consider supporting this for better convenience and usability for your users, especially since blocking such input does not value add much as compared to allowing for it.

soc-se-bot commented 2 months ago

Team's Response

Such issue is of valid concern especially for foreign names that contains special symbols. The team has actually taken note of this particular use case and it was unfortunately not included in the planned enhancements. Hence Accepted.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Over restrictive name validation to be only alphanumeric - some legal names not allowed

Description Set the context.

This app is used in a clinical context, which mean patient names are usually saved in full. However, some legal names containing non-alphanumeric characters are not allowed to be added into the system.

image.png

Steps to reproduce

  1. Launch the application for the first time to load initial data.
  2. Run add ic/S9987654A p/98887777 n/Ramy s/o Shanmugam g/M b/02-10-99 e/ramy@gmail.com d/General Flu

Expected behaviour

To be able to add this patient and his details.

Actual behaviour

Disallowed.

image.png

Reason for severity

This may cause inconvenience to the doctors who are not able to save their patients' names containing characters like ' or / or -, when they are common amongst people.


[original: nus-cs2103-AY2324S2/pe-interim#2957] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Such issue is of valid concern especially for foreign names that contains special symbols. The team has actually taken note of this particular use case and it was unfortunately not included in the planned enhancements. Hence Accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe that it is pretty common to have special characters such as à, ä, ö etc., in Singapore's context since there are many people from different parts of the world, and such characters are indeed common practices from these countries, as seen in the link below. (https://www.w3.org/International/questions/qa-personal-names) Consider the context of a clinical setting, where precision and accuracy are not just best practices but legal and ethical imperatives. Given that this is used in a clinical setting that is highly official, even storing NRIC details, it is especially important to record down the exact name of the patient to prevent the users (medical professionals) from accidentally referencing a different person's contacts. Medical professionals rely heavily on patient records to deliver safe and effective care. Mistakes in patient identification due to missing or incorrectly rendered special characters could have severe consequences, including misdiagnoses or improper treatments.