yleeyilin / pe

0 stars 0 forks source link

ADD Feature does not validate the age of the patients appropriately #5

Open yleeyilin opened 5 months ago

yleeyilin commented 5 months ago

Steps to reproduce:

Expected:

Actual:

Screenshots: image.png

This is problematic as this might be a typo on the part of the user and the lack of validation check on such input may reduce usability. You can consider supporting this for better convenience and usability for your users. One way you can do is by throwing a warning when such unrealistic age is being inputted.

soc-pe-bot commented 5 months ago

Team's Response

Though it might seem absurd regarding records that might have large value of age. Our team has actually allowed such behaviour as we aim for the user to have the flexibility to add medical records from the past as well this might be in use cases where clinics that might have been operating for a long time to migrate into our application. Though as stated in the expected section of the issue we it would definitely help to add some warning message and we have decided that this is something that can be pushed back to future releases. Thus, marking this as NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I do not quite understand why "clinics that might have been operating for a long time to migrate into our application" is related to allowing for a record that long ago. In reality, the concept of computerised record-keeping did not exist until a few decades ago.

There is clearly no need for any old clinic to have to migrate a 490 year old record into an existing record. In the real world, records dating back centuries would have long been merged, archived, or disposed of according to standard record-keeping practices.

Instead of burdening clinics with the unrealistic task of digitising records spanning nearly five centuries, it's far more reasonable and practical to focus on optimising record-keeping processes for current and relevant data. In this case, which is to throw a warning for the user.