search

yllieth / semantic-release-ms-teams

A plugin for semantic-release which publish release notes in a Microsoft Teams channel
MIT License
19 stars 15 forks source link

fix: use title and imageUrl from plugin config instead semantic-release config #15

Closed sedx closed 3 years ago

sedx commented 3 years ago

At the current realisation you should set image and title not in plugin config. It was read from semantic-release config.

Fix it.

Also title changes (even on top of semantic-release config) doest not affect. Looks like we should use title form config to activityTitle too

yllieth commented 3 years ago

Hi @sedx ! Thank you for your pull request. Just by reading the code quickly, everything seems fine. I'll give it a try asap, and hopefully release a new version with it.

yllieth commented 3 years ago

@sedx I merged your PR along with 2 other little things. v1.2.0 is here for your. Feel free to contact me if you have any problem with it.

sedx commented 3 years ago

@yllieth Thanks a lot! For quick PR merge and awesome plugin ;) all is fin now.