Amenities Decoupling/Refactoring

[ddrozdik]

I noticed that Amenities functionality is distributed across 4 main modules

• openy_txnm_amenities
• openy_prgf_amenities
• openy_prgf_location_by_amenities
• openy_block_branch_amenities

But also there is a reference to this functionality in other modules. For instance openy_ckeditor https://github.com/ymcatwincities/openy/blob/3930e9ab85af3c15265f3f7d1afcc8a768b76c04/modules/custom/openy_ckeditor/src/Plugin/CKEditorPlugin/ListBranchAmenities.php#L18

https://github.com/ymcatwincities/openy/blob/3930e9ab85af3c15265f3f7d1afcc8a768b76c04/modules/custom/openy_ckeditor/js/plugins/list_branch_amenities/plugin.js#L14

It looks like openy_ckeditor has been created only to contain things related to the amenities functionality.

It would be better to rename it or move the functionality related to amenities our of this module.

Pieces of code like this should be located in the general module specifically for Amenities https://github.com/ymcatwincities/openy/blob/75b518c721712e90d0f6e28eb60e1c280c5ef95b/modules/custom/openy_map/openy_map.module#L44

https://github.com/ymcatwincities/openy/blob/f0bb2436d9c46933e1b1138cccf7c26e1bb74a3b/modules/custom/openy_map/js/map.js#L445

[ddrozdik]

cc @podarok , @YMCA-GTC

[podarok]

@ddrozdik any updates on this?

[ddrozdik]

@podarok no updates so far, but this is still an issue.

[sarah-halby]

Demand is low and effort is high. Holding on this item until we have a higher demand.