ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 112 forks source link

ID's in the markup are tied to the theme name and cause CSS issues with activating a child theme. #1307

Open mikemuller opened 6 years ago

mikemuller commented 6 years ago

There are ID's that are added to the markup which reference the theme name. When a child theme is activated, the ID's change, breaking some of the styles on the page.

YMCA-GTC commented 6 years ago

Assigned IXM to dig into and discuss further with @podarok as needed

SanyokMedved commented 6 years ago

As it was researched there are no any id which are connected with theme name. As I can see css issues are not connected with tying to the theme name. @kolesnikoff

podarok commented 5 years ago

@mikemuller looks like we need your help to enlighten places where you faced with an issue Could you help?

paige-kiecker commented 5 years ago

@mikemuller is this still an issue you are encountering? We are moving it to our Issue backlog until we hear more information from you. Thanks.

sarah-halby commented 4 years ago

@mikemuller this item will continue to stay in our backlog until we are able to get more details from you on the issue. @podarok recalls that the theme was removed from CSS classes and that this issue was possible addressed through that update. We will revisit in 3 months and we'll close out if we cannot replicate the issue.

afi13 commented 3 years ago

The issue is not fixed, the selectors by IDs still used. Here just a few examples, but in fact, there are more of them https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L227 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L314 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_header.scss#L438 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L15 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L57 https://github.com/ymcatwincities/openy/blob/8.x-2.x/themes/openy_themes/openy_lily/sass/misc/_footer.scss#L75