Open anpolimus opened 4 years ago
@podarok , @paige-kiecker , please review.
@ivan-berezhnov , FYI
@anpolimus well. it is possible. Instead of using hardcoded classes there is a way to replace them by some css class that will do theming. I'm not sure how this should be configurable and how this is conflicting in your case It's pretty easy to change classes and recompile alerts for your case or better to analyse what is the conflict and how it could be avoided
@podarok in this case we need to give OpenY users ability to alter core changes according to their project needs. Right now I see that our team and 5Jars team have to use patches for such customization, which is not comfortable solution.
Probably this problem is equal to AF + Home Branch.
Lets add it to the discussion for that call.
@anpolimus - this is an item that is still up for discussion. We'll add to our discussion with the ImageX team @KylieAldridge
Hi. Is it possible to make array of classes for Alerts component to be configurable? https://github.com/ymcatwincities/openy/blob/8.x-2.x/modules/openy_features/openy_node/modules/openy_node_alert/js/openy-alerts/src/components/FooterAlertItem/FooterAlertItem.js#L64
We've faced that this hard-coded list of classes conflicts with our clients request. We made a temporary tricky fix for now, but if we could make it configurable or alterable - we could fix such issues more efficiently in the future.