search

ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Carnation/Lily: Small Banner image is output full size #2073

Open froboy opened 4 years ago

froboy commented 4 years ago

As seen on both: https://sandbox-lily-std.openy.org/ https://sandbox-carnation-std.openy.org/

See PageSpeed Insights for Carnation

The first image in the "Small Banner" paragraph is output directly instead of being passed through an image style. This can result in massive payloads for the browser. Even though the image needs to be very large, we should still run it through an image style to ensure it's compressed appropriately.

podarok commented 4 years ago

Here is a fix for Carnation https://github.com/ymcatwincities/openy/pull/2134 @froboy Let us know if this works for you

froboy commented 4 years ago

@podarok #2134 looks great. Thank you! Is there a plan to do the same for Lily?

podarok commented 3 years ago

https://github.com/ymcatwincities/openy/issues/2073 to verify if this was done for Lily and if so - backport it @shuklina and @dmytrolavrinenko

sarah-halby commented 3 years ago

@froboy we believe this issue is completed. Can you please take a look and see if you are still having this issue? https://github.com/ymcatwincities/openy/pull/2134 & https://github.com/ymcatwincities/openy/blob/96f56d862f27cc279ed2756f937182ca2fbd6b92/themes/openy_themes/openy_lily/openy_lily.theme#L108

sarah-halby commented 2 years ago

@froboy tagging you on this one for review - from your perspective, can we close this ticket?