ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 112 forks source link

Consider enabling webform ui module by default #2339

Open ddrozdik opened 3 years ago

ddrozdik commented 3 years ago

In the past module, webform_ui was enabled by default for all Open Y installation types https://github.com/ymcatwincities/openy/blob/2a5debf4c8146f93382ee9b8c92768f6a9d92629/openy.install#L337

However, now it is disabled by default. It can be enabled easily by adding into the list of dependencies for the Webform package https://github.com/ymcatwincities/openy/blob/8.x-2.x/openy.packages.yml#L297

We checked our live Open Y websites and noticed this module enabled on all of them. Some associations use it frequently.

We recommend enabling it by default.

podarok commented 3 years ago

UI modules in Drupal - modules as candidates for keeping disabled due to performance reasons. We all know how tough is cache clear - almost 0 sites could clear cache from Admin UI, almost 0 sites could enable a module from Admin UI and router(menu) contributes to this majority of the weight. UI modules are tough in terms of performance for admin interface.

I would keep them disabled and keep recommending to have it disabled in production. But if the community decided to enable it by default - we can make it. @sarah-halby

ddrozdik commented 3 years ago

@podarok, @sarah-halby Webform UI module is the only way to add anything to existing webforms or create a new one via the admin interface. All YMCA associations who work with Five Jars frequently create webforms on their own and they need access to this part of the admin interface.

Until then we handle this as customization.

sarah-halby commented 3 years ago

@sarah-halby to check with ImageX about their clients to determine how they use with their clients. This is a feature request. Would need to provide documentation and upgrade path.

ddrozdik commented 3 years ago

@sarah-halby it may look like a regression because this module was enabled by default at some point in the past, but then for some reason, it became disabled.

podarok commented 3 years ago

@ddrozdik webform_ui was introduced by webform community. Before it was a part of webform core