ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Daxko module looks outdated #2369

Open ddrozdik opened 3 years ago

ddrozdik commented 3 years ago

It seems daxko module(the first version) is outdated already and can be deleted from the distribution. Could you check it?

sarah-halby commented 3 years ago

@ddrozdik is this in regards to Activity Finder or just in general? I want to make sure @podarok has the information he needs to move forward.

ddrozdik commented 3 years ago

@sarah-halby in general, the module https://github.com/ymcatwincities/openy/tree/9.x-2.x/modules/custom/daxko was created 4 years ago. There are some dependencies to this module however, they are not relevant anymore. On the other hand, there is a module https://github.com/ymcatwincities/openy/tree/9.x-2.x/modules/custom/openy_daxko2 that works with API v2 and seems the most used across all Ys.

I don't have much information to decide that's why we need to investigate if we can safely deprecate it and remove it in future versions.

podarok commented 3 years ago

I agree that if we are not using it anymore - it is a good candidate for deprecation and decoupling to a dedicated repository just in case if needed I guess due to this is a change, functional change, we should be careful and we need to notify the community this is coming in the same way as we do for the media_*, openy_autocomplete_path, and some other modules, described in the upcoming February release as deprecated. @sarah-halby

sarah-halby commented 3 years ago

@ddrozdik can you confirm that your clients are not using this module? I will connect with OneEach, JW Tech, and ImageX. The plan is that the code is not removed and not decoupled, however, it will not be tested in new releases.

ddrozdik commented 3 years ago

@sarah-halby yes, I confirm we do not use it across all our clients.

podarok commented 2 years ago
 The service "openy_programs_search.data_storage" has a dependency on a non-  
  existent service "daxko.client".   
sarah-halby commented 2 years ago

@podarok should this ticket be closed after you confirm with IMX and YUSA that they are not using this module?