ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 112 forks source link

Search: Keep one Solr server instead of two #2393

Open ddrozdik opened 3 years ago

ddrozdik commented 3 years ago

Test Environment: Environment: | https://sandboxes-d9.openy.org/ Drupal version | 9.0.10 Open Y version | 9.x-2.8.0 Open Y installation type | Custom Open Y theme | Carnation

Description: In the sandbox environment, I noticed there are two Solr servers with almost the same name. The first one added via the Activity Finder v4 module https://github.com/ymcatwincities/openy_activity_finder/blob/4.x/config/optional/search_api.server.solr.yml and the second one added by Open Y Search API module https://github.com/ymcatwincities/openy/blob/9.x-2.x/modules/custom/openy_search/openy_search_api/config/install/search_api.server.solr_search.yml image

Both are configured almost identically. The only difference these modules use different indexes.

I suggest to modify these modules and develop a solution that will contain only one server. However, if two servers are needed, then at least rename Activity Finder Solr server.

podarok commented 3 years ago

@sarah-halby we have a bunch of dependencies we need to resolve before working on this one Virtual Y Solr search Open Y upgrade to decent Solr ( 8 ) Open Y Solr search Open Y Blogs search Activity Finder v3 Activity Finder v4

Also, we have some related issues which could be merged into one epic with current one

podarok commented 3 years ago

However is two servers are needed, then at least rename Activity Finder Solr server.

@sarah-halby this is our path short term. Let's discuss this on our scrum

sarah-halby commented 3 years ago

@ddrozdik please see @podarok comment above. Timing on this fix will be after the February release so we can address this and the upgrade path.

shelleygoetz commented 3 years ago

Can we get an estimate of back porting change plus supporting the upgrade path, as well as a priority level on this task @ddrozdik ?

ddrozdik commented 3 years ago

Hi @shelleygoetz. Sure, We will prepare the estimate.

hamrant commented 3 years ago

First of all, we need to revise modules listed in this comment - https://github.com/ymcatwincities/openy/issues/2393#issuecomment-766856501

In case the SOLR Server config is similar for all of them, we can create a new module in Open Y core Open Y Solr, that will contain only the SOLR Server config. The next step - add a dependency to this new Open Y Solr module in listed modules, add an update with removing old server configs, and update the dependency in index config + fix index names.

So we need some time to make this revision, make the final decision, then prepare a fix for several different repositories and test it well. I think it can take 10h.

Simple solution with only renaming indexes - 1h.

cc @ddrozdik @podarok @sarah-halby

sarah-halby commented 3 years ago

Medium priority per the 5Jars teams - still an issue.