Open podarok opened 3 years ago
@sarah-halby for us to discuss
Large ticket, probably about 20 hours. Might be able to do this if we can complete theme decoupling before 2022. Discuss again after November release @sarah-halby @podarok
One step in order to accomplish this task was done by ITCare for YMCA of the North instance - due to changes in forntawesome and design logic - @shuklina decoupled fontawesome solution in Alerts for Open Y. @dmytrolavrinenko to discuss this on upcoming call and to plan backporting to Open Y https://github.com/open-y-subprojects/openy_node_alert
We have different versions of Fontawesome icons/chars and it's adding additional maintenance effort in order not to lose any. Long term we should
Initial context Initial issue comment https://github.com/ymcatwincities/openy/pull/2414#issuecomment-786551252 If we want to use the latest version of Font Awesome in Carnation theme we should double check all icons before switch.
Here is a list of using of the Font Awesome icons that I found in Carnation theme SCSS fiels: https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/component/_addtocalendar.scss#L81 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_branch.scss#L182 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_branch.scss#L1339 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_geysir.scss#L5 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L19 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L121 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L126 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_location.scss#L68 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_news.scss#L54 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_site-alert.scss#L247 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_site-alert.scss#L255 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes /openy_carnation/src/scss/paragraphs/_amenities.scss#L279 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/paragraphs/_amenities.scss#L294
Other files:
cc @hamrant @podarok @aleevas