search

ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Make Fontawesome version consistent across the codebase #2415

Open podarok opened 3 years ago

podarok commented 3 years ago

We have different versions of Fontawesome icons/chars and it's adding additional maintenance effort in order not to lose any. Long term we should

Initial context Initial issue comment https://github.com/ymcatwincities/openy/pull/2414#issuecomment-786551252 If we want to use the latest version of Font Awesome in Carnation theme we should double check all icons before switch.

Here is a list of using of the Font Awesome icons that I found in Carnation theme SCSS fiels: https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/component/_addtocalendar.scss#L81 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_branch.scss#L182 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_branch.scss#L1339 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_geysir.scss#L5 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L19 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L121 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_global-search.scss#L126 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_location.scss#L68 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_news.scss#L54 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_site-alert.scss#L247 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/modules/_site-alert.scss#L255 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes /openy_carnation/src/scss/paragraphs/_amenities.scss#L279 https://github.com/ymcatwincities/openy/blob/8219b5a8911a1d98ce169a7fe3d7c9b04e789361/themes/openy_themes/openy_carnation/src/scss/paragraphs/_amenities.scss#L294

Other files:

dist/js/openy_carnation_branch.js:15:fas 
templates/modules/openy-faq-item.html.twig:18:fas 
templates/modules/openy-faq-item.html.twig:19:fas 
templates/paragraph/paragraph--gallery--default.html.twig:67:fas 
templates/paragraph/paragraph--gallery--default.html.twig:71:fas 
templates/openy_schedules/openy-schedules-main-class.html.twig:17:fas 
templates/openy_schedules/openy-schedules-main-class.html.twig:18:fas 
templates/openy_schedules/openy-schedules-main-class.html.twig:59:fas 
templates/openy_schedules/openy-schedules-main.html.twig:51:fas 
templates/field/field--field-location-directions.html.twig:46:fas 
templates/field/field--field-location-directions.html.twig:53:fas 
templates/field/field--field-location-directions.html.twig:65:fas 
templates/field/field--address.html.twig:45:fas 
templates/block/block-branch-contacts-info.html.twig:30:fas 
templates/block/block-branch-contacts-info.html.twig:49:fas 
templates/elements/openy-class-sessions.html.twig:54:fas 
templates/elements/openy-class-sessions.html.twig:60:fas 
templates/node/facility/node--facility--full.html.twig:100:fas 
templates/node/facility/node--facility--full.html.twig:108:fas 
templates/node/facility/node--facility--full.html.twig:140:fas 
templates/node/branch/node--branch--class_location.html.twig:108:fas 
templates/node/news/node--news--full.html.twig:130:fas 
templates/node/node--location-type--teaser.html.twig:101:fas 
templates/node/node--location-type--teaser.html.twig:107:fas 
templates/node/node--location-type--teaser.html.twig:123:fas 
templates/node/node--location-type--teaser.html.twig:131:fas 
templates/node/camp/node--camp--class_location.html.twig:106:fas 
templates/node/event/event-location-info.html.twig:22:fas 
templates/node/event/node--event--teaser.html.twig:109:fas 

dist/js/openy_carnation_program.js:23:fa 
dist/js/openy_carnation_program.js:24:fa 
templates/paragraph/paragraph--grid-columns.html.twig:53:fa 
templates/menu/mobile/menu--main--mobile-menu.html.twig:42:fa 
templates/menu/mobile/menu--main--mobile-menu.html.twig:43:fa 
templates/menu/menu--main--primary-menu.html.twig:42:fa 
templates/menu/menu--main--primary-menu.html.twig:43:fa 
templates/menu/menu--main--primary-menu.html.twig:56:fa 
templates/menu/menu--main--primary-menu.html.twig:73:fa 
templates/openy_schedules/openy-schedules-subcategory-filters.html.twig:18:fa 
templates/field/field--paragraph--3c.html.twig:69:fa 
templates/field/field--paragraph--1c.html.twig:65:fa 
templates/field/field--paragraph--4c.html.twig:79:fa 
templates/field/field--node--field-page-related-content.html.twig:51:fa 
templates/field/field--node--field-blog-related--blog.html.twig:51:fa 
templates/field/field--node--field-location-state.html.twig:52:fa 
templates/field/field--paragraph--2c.html.twig:63:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:18:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:20:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:23:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:25:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:110:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:168:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:221:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--table.html.twig:318:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:29:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:30:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:52:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:53:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:68:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:69:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:100:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:101:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:126:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard--sidebar.html.twig:127:fa 
templates/openy_repeat/openy-repeat-schedule-dashboard.html.twig:26:fa 
templates/block/block-branch-contacts-info.html.twig:25:fa 
templates/block/block-branch-contacts-info.html.twig:41:fa 
templates/views/views-view-field--social-posts-view--social-posts-block--field-platform.html.twig:1:fa 
templates/openy_group_schedules/groupex-table-class-individual.html.twig:21:fa 
templates/openy_group_schedules/groupex-table-class-individual.html.twig:26:fa 
templates/openy_group_schedules/groupex-table-class-individual.html.twig:26:fa 
templates/openy_group_schedules/groupex-table-instructor-individual.html.twig:17:fa 
templates/openy_group_schedules/groupex-table-instructor-individual.html.twig:20:fa 
templates/openy_group_schedules/groupex-table-instructor-individual.html.twig:21:fa 
templates/openy_group_schedules/groupex-table-class.html.twig:17:fa 
templates/openy_group_schedules/groupex-table-class.html.twig:20:fa 
templates/openy_group_schedules/groupex-table-class.html.twig:20:fa 
templates/page/page.html.twig:88:fa 
templates/page/page.html.twig:129:fa 
templates/page/page.html.twig:134:fa 
templates/node/facility/node--facility--full.html.twig:135:fa 
templates/node/facility/node--facility--full.html.twig:156:fa 
templates/node/facility/node--facility--full.html.twig:162:fa 
templates/node/alert/node--alert--node-alert-header.html.twig:89:fa 
templates/node/alert/node--alert--node-alert-header.html.twig:108:fa 
templates/node/alert/node--alert--node-alert-footer.html.twig:89:fa 
templates/node/alert/node--alert--node-alert-footer.html.twig:108:fa 
templates/node/extends/post-teaser--default.html.twig:52:fa 
templates/node/news/node--news--teaser.html.twig:92:fa 
templates/node/news/node--news--full.html.twig:123:fa 
templates/node/event/event-location-info.html.twig:28:fa 
templates/node/event/event-contact-info.html.twig:21:fa 
templates/node/event/event-contact-info.html.twig:25:fa 
templates/node/event/event-contact-info.html.twig:29:fa

cc @hamrant @podarok @aleevas

podarok commented 3 years ago

@sarah-halby for us to discuss

shelleygoetz commented 2 years ago

Large ticket, probably about 20 hours. Might be able to do this if we can complete theme decoupling before 2022. Discuss again after November release @sarah-halby @podarok

podarok commented 2 years ago

One step in order to accomplish this task was done by ITCare for YMCA of the North instance - due to changes in forntawesome and design logic - @shuklina decoupled fontawesome solution in Alerts for Open Y. @dmytrolavrinenko to discuss this on upcoming call and to plan backporting to Open Y https://github.com/open-y-subprojects/openy_node_alert