feat(flexibility): Do not make Open Y dependent from page cache module

podarok commented 3 years ago

See https://www.drupal.org/docs/drupal-apis/cache-api/cache-max-age#s-limitations-of-max-age

If somebody uses CloudFlare or Varnish - page_cache makes permanent cache and breaks TTL logic We should not depend from page_cache in order for CloudFlare/Varnish users to have proper Browser Cache logic by not using Page Cache module

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

[ ] Check if page_cache can be uninstalled

General checks

[ ] All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
[ ] Try to use Conventional commit messages accordingly to the standard https://www.conventionalcommits.org/en/v1.0.0/#specification
[ ] Documentation has been updated according to PR changes.
[ ] Steps for review have been provided according to PR changes.
[ ] Make sure you've provided all necessary hook_update_N to support upgrade path.
[ ] Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
[ ] If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3333/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3333/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3333/

podarok commented 3 years ago

Checked on a build, can be uninstalled Thanks for approval @anpolimus @danylevskyi

shelleygoetz commented 3 years ago

Moved to Jira: https://openy.atlassian.net/browse/MAINTAIN-163

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3336/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3336/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3336/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3337/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3337/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3337/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3338/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3338/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3338/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3339/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3339/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3339/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3340/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3340/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3340/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3341/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3341/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3342/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3342/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3341/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3342/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3344/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3344/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3343/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3343/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3344/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3343/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3345/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3345/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3346/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3346/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3345/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3346/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3347/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3347/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3347/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3348/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3348/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3348/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3349/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3349/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3349/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3350/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3350/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3350/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3351/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3351/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3352/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3352/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3351/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3352/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3353/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3353/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3353/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3354/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3354/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3355/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3355/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3354/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3355/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3356/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3356/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3356/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3357/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3357/

gundevel commented 3 years ago

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3358/install.php

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3358/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3357/

gundevel commented 3 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3358/

ymcatwincities / openy