Open froboy opened 2 years ago
@shelleygoetz can you open a ticket in the maintain backlog for this issue?
I guess this should go via Ben's review @sarah-halby Carnation was created without icons for a reason. Let's ensure we have a good UX when enabling them in themes, which weren't created with them
@sarah-halby Let me know if you want me to create a Jira ticket for this or hold based on @podarok's response above.
@shelleygoetz let's hold on this for now. We'll need Ben's time for this and his bandwidth is strapped at the moment.
Ben here. Thanks for the consideration! Since this isn't my theme, my suggestion would be to ask the creator's opinion (if possible) before making any decisions.
In this case, Image X created the Carnation theme. And with credit to them, we should ask them what they think. If they're all for it (or not against it), then it becomes an addition with considering. Then, at that point, we should ask if and how they might like to see it implemented.
Thanks, @llamarama - @KylieAldridge suggested that we do implement this based on their client experience. Kylie, what would be your suggestion for a client to backport this from? @shelleygoetz please add a Jira ticket for the maintain board so we can get this backported from the IMX team.
Jira ticket created here: https://openy.atlassian.net/browse/MAINTAIN-186
Icons for second-level menu items are supported in Rose, but not Carnation. Lily doesn't use mega-menus so its implementation might not make sense.
A few sites like https://www.ymcamissoula.org/, https://www.akronymca.org/ have implemented this, but all with custom CSS. We should be able to use the
Icon image
field on menu items to write the CSS usingsimple_menu_icons
. https://github.com/ymcatwincities/openy/blob/8cabff0412e52d30d813c7b8abbde4fd1b9b05e7/themes/openy_themes/openy_lily/sass/modules/_menu.scss#L361