search

ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Carnation: Support mega menu icons #2564

Open froboy opened 2 years ago

froboy commented 2 years ago

Icons for second-level menu items are supported in Rose, but not Carnation. Lily doesn't use mega-menus so its implementation might not make sense.

Open_Y___Drush_Site-Install_and_Open_Y___Drush_Site-Install_—__Private_Browsing_ e

A few sites like https://www.ymcamissoula.org/, https://www.akronymca.org/ have implemented this, but all with custom CSS. We should be able to use the Icon image field on menu items to write the CSS using simple_menu_icons. https://github.com/ymcatwincities/openy/blob/8cabff0412e52d30d813c7b8abbde4fd1b9b05e7/themes/openy_themes/openy_lily/sass/modules/_menu.scss#L361

sarah-halby commented 2 years ago

@shelleygoetz can you open a ticket in the maintain backlog for this issue?

podarok commented 2 years ago

I guess this should go via Ben's review @sarah-halby Carnation was created without icons for a reason. Let's ensure we have a good UX when enabling them in themes, which weren't created with them

shelleygoetz commented 2 years ago

@sarah-halby Let me know if you want me to create a Jira ticket for this or hold based on @podarok's response above.

sarah-halby commented 2 years ago

@shelleygoetz let's hold on this for now. We'll need Ben's time for this and his bandwidth is strapped at the moment.

llamarama commented 2 years ago

Ben here. Thanks for the consideration! Since this isn't my theme, my suggestion would be to ask the creator's opinion (if possible) before making any decisions.

In this case, Image X created the Carnation theme. And with credit to them, we should ask them what they think. If they're all for it (or not against it), then it becomes an addition with considering. Then, at that point, we should ask if and how they might like to see it implemented.

sarah-halby commented 2 years ago

Thanks, @llamarama - @KylieAldridge suggested that we do implement this based on their client experience. Kylie, what would be your suggestion for a client to backport this from? @shelleygoetz please add a Jira ticket for the maintain board so we can get this backported from the IMX team.

shelleygoetz commented 2 years ago

Jira ticket created here: https://openy.atlassian.net/browse/MAINTAIN-186

froboy commented 2 years ago

MR is open at https://www.drupal.org/project/openy_carnation/issues/3265743#comment-14421341