ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Move Drush to the development section of the makefile for Aegir compatibility #2604

Closed colans closed 2 years ago

colans commented 2 years ago

Currently, it's not possible to install a Y site on Aegir because it requires a site-local Drush. See Aegir 3 is incompatible with Drush 9+ for details.

Given that Drush isn't generally required for Production sites, the simplest and best-practice workaround is to move it from require to require-dev so that it's still available in development environments, but not in Aegir deployments (which always assume Production).

Original Issue, this PR is going to fix: NA; this MR is self-contained.

Steps for review

  1. Get access to an Aegir instance by setting it up on a real VM or by using https://gitlab.com/aegir/aegir-dev-vm.
  2. Create a new Platform (Aegir-speak for a Drupal codebase) using https://github.com/ymcatwincities/openy-project.
  3. Create a site using the Open Y distro on that Platform.

If everything is green, it succeeded. If you get errors as described in Aegir 3 is incompatible with Drush 9+, then it failed.

General checks

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

sarah-halby commented 2 years ago

@podarok can you please review? @shelleygoetz please open a ticket in Jira.

podarok commented 2 years ago

There is a chance CI will be broken, I'll verify overnight @sarah-halby

Thank you @colans

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

colans commented 2 years ago

Thanks! That was fast. I created a d.o issue for credit purposes @ https://www.drupal.org/project/openy/issues/3253330

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

podarok commented 2 years ago

Thanks! That was fast. I created a d.o issue for credit purposes @ https://www.drupal.org/project/openy/issues/3253330

Fixed on drupal.org. Thank you

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

shelleygoetz commented 2 years ago

@sarah-halby created: (https://openy.atlassian.net/browse/MAINTAIN-222)

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

podarok commented 2 years ago

[skip ci]

gundevel commented 2 years ago

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.