search

ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

Alerts: empty space after closing the second alert #2630

Closed Juliazk closed 2 years ago

Juliazk commented 2 years ago

Issue description: If a user clicks the arrow to see the second Alert and clicks "Close", empty space will be displayed in place of Alert.

Steps to reproduce:

  1. Go to the page with Alerts (there should be at least 2 Alerts to view);
  2. Click the arrow to swipe the first Alert and view the second one;
  3. Click "Close" to hide alerts.

Actual result: When a user closes the second alert, empty space gets displayed. image Expected result: The header should fill in empty space.

Juliazk commented 2 years ago

@KylieAldridge Hello! We can backport the solution for the issue. I will keep you posted.

manachynskyi commented 2 years ago

Fixed there https://github.com/open-y-subprojects/openy_node_alert/pull/64 , steps for review in the PR.

cc @podarok @froboy @KylieAldridge

podarok commented 2 years ago

merged, compiled and tagged in https://github.com/open-y-subprojects/openy_node_alert/releases/tag/1.1.11 Thanks