ymcatwincities / openy

The Open Y platform. See README.md below
https://openy.org
GNU General Public License v3.0
49 stars 111 forks source link

fix: allow css_editor v2 #2639

Closed podarok closed 2 years ago

podarok commented 2 years ago

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

General checks

Thank you for your contribution!

gundevel commented 2 years ago

Refer to this link for build results (access rights to CI server needed): http://openy.cibox.tools:8080//job/PR_BUILDER_COMPOSER/3733/

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3733/install.php

froboy commented 2 years ago

@podarok is there any reason to keep compatibility with 1.x? It seems like that would just allow folks to stay on the old (broken) version.

gundevel commented 2 years ago

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3733/

podarok commented 2 years ago

@froboy There is a reason to simplify upgrade path as well as to show what was before. Instead of forcing upgrade, we are adding a bit of freedom for maintainers. We don't know if newer version could be run on older core or php. Remember, YMCA usually a couple versions behind.

gundevel commented 2 years ago

Open Y Complete profile installed at http://profile.openy.cibox.tools/build3733/

froboy commented 2 years ago

@podarok sure, I get the general concept, but in this case we're dealing with a small but significant update and a... generally trustworthy maintainer. 😛 I'll leave it to you though and I've closed my PR.

https://git.drupalcode.org/project/css_editor/-/compare/8.x-1.3...2.0.1?from_project_id=18108

podarok commented 2 years ago

@podarok sure, I get the general concept, but in this case we're dealing with a small but significant update and a... generally trustworthy maintainer. 😛

https://git.drupalcode.org/project/css_editor/-/compare/8.x-1.3...2.0.1?from_project_id=18108

Completely agree, except of the future updates. It's today we know all good. But in 2 months there will be 2.0.9, which could introduce issue.

So it's better to have more room