ymcatwincities / openy_activity_finder

Activity Finder for Open Y
https://github.com/YCloudYUSA/yusaopeny_activity_finder
GNU General Public License v3.0
3 stars 24 forks source link

[AF4] Categories exclusion #7

Open duozersk opened 3 years ago

duozersk commented 3 years ago

AF3 has categories limitation / exclusion settings - we should support them in AF4. There are also categories exclusion settings on the backend - and this might be enough for most cases.

The settings we might want to support are implemented as paragraph fields and then rendered to the page using the “Data exported in JSON format“ / openy_json formatter which pushes field values to the window.OpenY.field_name JS values.

Apparently we can support the same setting not as paragraph fields, but as block settings - and render them to the page in the Twig template as we already do with all other settings - especially in the light of Layout Builder coming to Open Y (better to use blocks directly without wrapping paragraph).

podarok commented 3 years ago

@sarah-halby FYI ^^^

duozersk commented 3 years ago

We need this one on YGBW as they have a thing called Camp Finder and it requires different set of excluded categories on paragraph/block level - will work on it.

podarok commented 3 years ago

@duozersk this one? https://github.com/ymcatwincities/openy/pull/1964

duozersk commented 3 years ago

@podarok Yes, this one. We are tasked to have the same functionality based on AF4.

podarok commented 3 years ago

You mentioned "partially". so reopening this one @duozersk

duozersk commented 3 years ago

Correct @podarok - we have implemented the exclude part; but there is also the limit part - limit found activities by categories - which wasn't done.

duozersk commented 3 years ago

40 improves the categories exclusion logic.

duozersk commented 3 years ago

And #44 hopefully takes us to the finish line with the exclusions :)

shelleygoetz commented 2 years ago

@sarah-halby Jira ticket created - https://openy.atlassian.net/browse/MAINTAIN-202