ymcatwincities / openy_gated_content

Virtual YMCA
https://openy.org
GNU General Public License v3.0
5 stars 28 forks source link

1.4 #137

Closed anpolimus closed 3 years ago

anpolimus commented 3 years ago

Related Issue/Ticket:

PLEASE CHECK BASE BRANCH FOR YOUR PR ONLY urgent and approved fixes for point release should go to master branch

(Replace this line with a link to the related GitHub issue on ymcatwincities/openy_gated_content or your own ticketing system)

Steps to test:

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

ghost commented 3 years ago

DeepCode's analysis on #d0a193 found:

Description Example fixes
Comparing a string (from string literal "beep") and a number (from number literal 0) with strict operator is pointless, they can never be equal. Occurrences: :wrench: Example fixes
Accessing attribute attributes on a null/undefined value. null/undefined value flows from a null literal. Occurrences: :wrench: Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot