search

ymcatwincities / openy_gated_content

Virtual YMCA
https://openy.org
GNU General Public License v3.0
5 stars 28 forks source link

Vimeo: Support for Timecode feature #142

Closed TomScarboroughYMCA closed 2 years ago

TomScarboroughYMCA commented 3 years ago

Description

Vimeo has a Timecode feature that let's you start a video several seconds in by appending a tag to the video URL: "#t=s" where "" is a time, in this case, seconds denoted by the "s". So "#t=20s" appended to the end of the video URL would start the video 20 seconds in.

The below URL works great when put in a browser, but when added to the Virtual Y site, it doesn't work:

https://vimeo.com/499320587/5391090884#t=36s

Acceptance Criteria

When using the Timecode feature and appending the timecode tag to the end of the video url, the video will start at the proposed time guided by the Timecode value when viewed within the Virtual Y site.

shelleygoetz commented 2 years ago

Jira ticket is here for when this issue is ready for testing: https://openy.atlassian.net/browse/PRODDEV-471

sarah-halby commented 2 years ago

@TomScarboroughYMCA this has passed QA. It will be put in the distribution for the December point release. If your team needs it, you have the PR ready to go. Once the PR is closed, we can close this ticket.

TomScarboroughYMCA commented 2 years ago

Thank you @sarah-halby !

sarah-halby commented 2 years ago

This has passed QA and the patch is available now. It will be released in the Dec point release.