search

ymgve / bitcoin_fork_claimer

Script for transferring/claiming your coins on various Bitcoin forks
202 stars 85 forks source link

Offline signing #61

Open Steve132 opened 6 years ago

Steve132 commented 6 years ago

I wrote (but didn't completely test 100%) a patch to allow offline signing on an airgapped computer to prevent users from needing to expose their private keys to an online computer in order to access a fork. This patch also is important because it allows including claimer.py as a module (which is not currently possible because there is no if __name__=='__main__': check)

forkdrop commented 6 years ago

It's a great feature, but the diff is hard to read due to the additional refactoring. A lot of people rely on this code for correctness and it needs to audited. I personally would prefer if there were separate commits and/or PRs to split the refactoring from the new functionality.

Steve132 commented 6 years ago

You can't really add the feature without refactoring it into subparts to make some parts optional. As far as I know that's the only change I made in this diff.

On Wed, Jul 4, 2018, 11:50 AM Forkdrop.io notifications@github.com wrote:

It's a great feature, but the diff is hard to read due to the additional refactoring. A lot of people rely on this code for correctness and it needs to audited. I personally would prefer if there were separate commits and/or PRs to split the refactoring from the new functionality.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ymgve/bitcoin_fork_claimer/pull/61#issuecomment-402514653, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1kMGQFF_BbtYCVjSpxQRXj94bLn3iEks5uDOQ8gaJpZM4U2gWv .

Steve132 commented 6 years ago

Okay, I can fix it with multiple commits.