ymgve / bitcoin_fork_claimer

Script for transferring/claiming your coins on various Bitcoin forks
202 stars 85 forks source link

BCH: Script not accepting BCH wallet addresses #78

Closed outhud closed 5 years ago

outhud commented 5 years ago

Trying to claim BCH.

When I use a bitstamp BCH deposit address (beginning with 3...) I get

Candidate transaction, index 0 with XXX Satoshis (XXX BTC)
YOU ARE TRYING TO SEND TO A P2SH ADDRESS! THIS IS NOT NORMAL! Are you sure you know what you're doing?

Write 'I am aware that the destination address is P2SH' to continue

Is it OK to go ahead with this?

Bitstamp has an option to display a bech32 address, when I use that (beginning with bitcoincash:pr...) I get:

Candidate transaction, index 0 with XXX Satoshis (XXX BTC)
Traceback (most recent call last):
  File "claimer.py", line 1515, in <module>
    amount = int(amount)
ValueError: invalid literal for int() with base 10: 'pr.<snip>.'

I get the same error when I try to use an address made with Electron Cash wallet.

outhud commented 5 years ago

I was able to get it working by converting the Electron Cash wallet address to Legacy format using https://cashaddr.bitcoincash.org/