search

ymichael / everdell

🐿️ Play Everdell Online!
https://everdell.vercel.app/
MIT License
34 stars 11 forks source link

Refactoring card definitions #63

Closed lilasquared closed 2 years ago

lilasquared commented 2 years ago

Before I commit to this (pun intended) I wanted to suggest a refactoring like this to get card definitions into their own files.

I am happy to follow up with other model instances too if this seems reasonable.

I am interested in contributing some features as well just trying to get my bearings in the codebase first!

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @ymichael on Vercel.

@ymichael first needs to authorize it.

ymichael commented 2 years ago

hi! I'm curious what you see as the benefit of doing this is. I'm not sure if it is just because I've gotten familiar with the existing setup but I quite like having everything in one file (most of the code in these files are unchanged once implemented with the exception of the occasional bug fixes so I'm not sure we'll gain too much unless we also plan to do further refactoring / code changes after splitting the entities into their own files)

lilasquared commented 2 years ago

It mostly just seems easier for someone coming onto the project to understand if things are separated out, and then makes future bug fixes or refactorings easier as well (IMO). I like having easier chunks of code to digest but it's your project so if you don't think there is a benefit then i can work around it.

ymichael commented 2 years ago

ok sounds good - lets leave this alone for now then!