Closed danielroe closed 2 months ago
0 | 4 | 0 | 0 | 0 |
Details:
Merge 35fed11c90f04660ee2b249641b39a3a7be1a325 into d005d50ea79d15a9afd79139e154... | |||
Project: nuxt-jsonld | Commit: 87d650baa6 ℹ️ |
||
Status: Passed | Duration: 00:05 💡 | ||
Started: Dec 21, 2023 3:11 PM | Ended: Dec 21, 2023 3:11 PM |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d005d50
) 100.00% compared to head (35fed11
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a 'canary' pull request. It aims to ensure that the ecosystem is ready for a shift in the default Nuxt TypeScript module resolution from 'Legacy' to 'Bundler': https://github.com/nuxt/nuxt/pull/24837. You'll need to run your build + type checking tests to verify that things still work; I'm hoping that CI will do that for us so we get an immediate indication of whether there's anything to investigate further here.
'Bundler' module resolution is recommended by Vue and by Vite, but unfortunately there are still many packages that do not have the correct entries in their
package.json
.This might include this module or packages that are used by this module. You can see, for example: https://arethetypeswrong.github.io/?p=nuxt-jsonld. The initial red X for
node10
needs to be fixed in https://github.com/nuxt/module-builder; you can ignore that for now.If there are any errors reported in CI for this PR, it would be good to fix them for the sake of any users of this module who enable the Bundler module resolution. Feel free to ping me or others on the Nuxt Discord if you need any help resolving any issues discovered by this PR - and feel free to check out https://github.com/nuxt/nuxt/pull/24837 for any feedback or comments from others affected.