search

ymotongpoo / vsc-licenser

License handler extension for Visual Studio Code.
Apache License 2.0
45 stars 40 forks source link

Do not save after an operation. #119

Closed teo-tsirpanis closed 2 years ago

teo-tsirpanis commented 2 years ago

Fixes #114.

This PR removes all save calls from the extension's source code, and also removed and replaced some deprecated function calls.

ymotongpoo commented 2 years ago

Hi @teo-tsirpanis, I misread the original issue comment. Could you make change to be an option? i.e. Could you leave an option to do autosave? You may add an extension setting for it.

ymotongpoo commented 2 years ago

@teo-tsirpanis kindly ping. do you have any comments on my request? Again, thank you for your contribution.

teo-tsirpanis commented 2 years ago

Hello, I am busy these days; it will take me some time until I can work on it.

teo-tsirpanis commented 2 years ago

I am working on it. How about never saving after the automatic header insertion on a new file only? It would address my second bullet point in #114 by default, and I don't imagine anyone wanting this behavior.

ymotongpoo commented 2 years ago

How do you differentiate "temporary" file and intended new files? Because I don't use VS Code for temporary files, so I prefer auto save. That's the reason why I asked for "opt-out" toggle config for it.

teo-tsirpanis commented 2 years ago

OK @ymotongpoo, I added the configuration option. Can you take a look?

I also upgraded package-lock.json to version 2.

teo-tsirpanis commented 2 years ago

It already is @ymotongpoo, I have contributed before: https://github.com/ymotongpoo/vsc-licenser/blob/2272819f6855dd32705d18f83684df716623f844/CONTRIBUTORS#L13

ymotongpoo commented 2 years ago

Thanks for the repeated contribution, @teo-tsirpanis!