search

ymotongpoo / vsc-licenser

License handler extension for Visual Studio Code.
Apache License 2.0
45 stars 40 forks source link

fix: upgrade from tslint to eslint as the former is deprecated #125

Closed akkumar closed 2 years ago

akkumar commented 2 years ago

Migrate from tslint to eslint ..

`tslint-to-eslint-config.log says the following: 

3 ESLint rules behave differently from their TSLint counterparts:
  * brace-style:
    - ESLint's brace-style will check all tokens.
  * eqeqeq:
    - Option "smart" allows for comparing two literal values, evaluating the value of typeof and null comparisons.
  * no-underscore-dangle:
    - Leading or trailing underscores (_) on identifiers will now be forbidden.

1 rule is not known by tslint-to-eslint-config to have an ESLint equivalent:
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "whitespace".
akkumar commented 2 years ago

There is a very nice eslint plugin to find deprecated API - eslint-plugin-deprecation .

Currently - that plugin does not seem to support eslint 8.x though - eslint-plugin-deprecation/#37

Hence followed the hack as per the discussion in that thread.

akkumar commented 2 years ago

@ymotongpoo - FYI . Committed the changes.