search

ymotongpoo / vsc-licenser

License handler extension for Visual Studio Code.
Apache License 2.0
45 stars 40 forks source link

Feature: Choose a license type when creating a new file #55

Closed ibraimgm closed 5 years ago

ibraimgm commented 5 years ago

Created a new license type choose that, if selected, aloows the user to select the desired license type from a list. Demo of the final result:

licenser

IMPORTANT: Since I don't really know typescript or any typescript/vscode best practices, I tried to do the simplest thing that works. Feedback will be appreciated.

ymotongpoo commented 5 years ago

@ibraimgm thanks for the PR. the feature in general looks good, but I prefer the name something better than choose, such as dynamic. Furthermore, it could be more longer, say 2+ words, explicit name so that the user can understand it is the special setting that allows users to define the license dynamically.

ibraimgm commented 5 years ago

@ymotongpoo Agreed, choose may not be descriptive enough. Updated it to Choose from list, let me know if there is any other problem.

ibraimgm commented 5 years ago

Done. Changed it to a constant and rebased.

ymotongpoo commented 5 years ago

@ibraimgm I appreciate your contribution. merged!