ynab / ynab-sdk-js

YNAB API Client for JavaScript
https://api.ynab.com
Apache License 2.0
217 stars 20 forks source link

Node v21.7.3 prints out deprecation warning on import #165

Open nwwells opened 5 months ago

nwwells commented 5 months ago

Whenever ynab is imported I get the following printed to the console:

(node:52279) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Rerunning with --trace-deprecation shows the following:

(node:52535) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10)
    at loadBuiltinModule (node:internal/modules/helpers:104:7)
    at Module._load (node:internal/modules/cjs/loader:999:17)
    at Module.require (node:internal/modules/cjs/loader:1230:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> ({my project directory}/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
    at Module._compile (node:internal/modules/cjs/loader:1368:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1426:10)

Relevant part of the dependency tree

└─┬ ynab@2.2.0
  └─┬ fetch-ponyfill@7.1.0
    └─┬ node-fetch@2.6.13
      ├── UNMET OPTIONAL DEPENDENCY encoding@^0.1.0
      └─┬ whatwg-url@5.0.0
        ├── tr46@0.0.3
        └── webidl-conversions@3.0.1
bradymholt commented 4 months ago

Relevant issue: https://github.com/node-fetch/node-fetch/pull/1793. It looks like the [fetch-ponyfill] dependency version (https://github.com/qubyte/fetch-ponyfill) is using node-fetch@2 which is source of this deprecation notice.