ynab / ynab-sdk-js

YNAB API Client for JavaScript
https://api.ynab.com
Apache License 2.0
217 stars 20 forks source link

Generate from spec version 1.70.0 #167

Closed bradymholt closed 3 months ago

bradymholt commented 3 months ago

Generate based on server spec version 1.70.0.

joshmenden commented 3 months ago

Nice this looks good. I ran a few smoketests with the dependency pointed at this branch and everything looks good.

One thought I have for future reference. When I tried to run this generator in this repo a month ago or so I ran into this issue: https://github.com/OpenAPITools/openapi-generator/issues/18746

Which has since been resolved. I was running with version 7.5.0 and you here are using 7.6.0 with the patch.

It made me think we should use docker for the API generation script, since we can then hard-code the generator version into the docker image. Something like they have in their docs

docker run --rm \
    -v $PWD:/local openapitools/openapi-generator-cli generate \
    -i /local/petstore.yaml \
    -g go \
    -o /local/out/go

Then we wouldn't be dependent on whatever latest version somebody gets when the do brew install and can manually up the version as we have time.

I can create an issue to tackle this down the road.

bradymholt commented 3 months ago

Thanks for review.