ynazar1 / Arh

WoW Archaeology Helper addon
Other
24 stars 2 forks source link

Cata Classic Support #12

Closed Walayimuna closed 4 months ago

Walayimuna commented 6 months ago

Any plans to make it compatible with cataclysm classic?

ynazar1 commented 6 months ago

Since classic uses same API as retail it may just 'work'.... but I don't play classic so i'm unlikely to be able to do any real testing.

I'm happy to collaborate to get it working, but my skills in wow addons is at a level of 'occasional bugfix'. I'm not particularly confident to maintaining two distinct sets of code between editions if there are significant differences.

Walayimuna commented 6 months ago

I can help in any way I know, maybe beta-test or something, when archaeology becomes available on PTR

ynazar1 commented 6 months ago

We could try it out once Cataclysm reaches open beta or release. But there's been number of relevant API changes in the intervening years that would specifically affect Arh. Super ironically, the OLDER versions on curse may just work in Cata since they would use old APIs.

This article deals with some addon changes between retail and Classic and I can tell you that most of these changes affect Arh.

The original code is basically been hacked at by many people and while some things are simply commented out, there are other functions that I know were completely replaced over the years so they'll be hard to recover. You may see some examples of changes that have been done here and these types of changes are specifically outlined in the article about porting. This one for example is above my skill level to unravel if it needs to be fixed or redone.

TamerLee commented 5 months ago

Can confirm the latest version works on the Cataclysm beta. The two features not working at the moment are the node database, and being able to record new nodes.

ynazar1 commented 5 months ago

Awesome. I don't have beta so I may need to wait till it opens up. The two things you mention hard-depend on GatherMate2 as It simply adds nodes to GatherMate's database.

Walayimuna commented 5 months ago

I'm offering to beta test if needed, I have access to the beta

vtosh commented 5 months ago

Can also confirm this appears to be working absolutly great on cata beta. At least in terms of keybinding dig/undo/red/yellow/green. Getting mounted automatically when using red/yellow markers (using the mount favorite no less!). Undo works correctly as well through multiple undo steps

As mentioned, node stuff isn't working. I assume thats because the "view" is a clone of the minimap in some form (like how farmhud works) which is why thats all gathermates realm? Unfortunatly we don't have a cata version of that yet. It was never officially backported to classic so we have gathermate2 classic instead, which only supports up to wotlk atm, and the retail version isn't compatible

vtosh commented 5 months ago

I managed to hack together a working version of gathermate2. I can now see nodes appear, however innitially the nodes didn't rotate with the camera. Toggling rotate minimap manually, then reloading the UI allowed the nodes to rotate with the camera. I'm assuming however this is just a part of gathermate2 that i didn't manage to correctly hack together, and will be fixed when an official cata version is released

ynazar1 commented 5 months ago

@vtosh : I betcha it's related to #5

Check what the variable name on these lines here Vs What is it around line 27 of Gathermate2: Display.lua file (look for rotation).

They must match

vtosh commented 5 months ago

Haha, I even had a diff of retail and classic Display.lua from gathermate2 open and I must have missed that cvar rename.

But that all but confirms, no changes appear to be required to support cata classic. The only thing that might be usful is adding an additional cata toc file, so it can be used without loading out of date addons (but given everyone in classic probably has that enabled not a problem). Other than that thanks for maintaining it!

Walayimuna commented 5 months ago

So I can just get this addon as is and use it on cata?

ynazar1 commented 4 months ago

@Walayimuna yes. Current version works fine. I was able to verify it as I got Cata beta access.

It works as is, but without gathermate2's archaeology tracking there are no nodes that show up on the HUD. Hopefully they'll put it back in once live.

Two known bugs:

  1. gathermate2 dependency Intentional: ~2. Druid shifts into travel form instead of flight form because they are different things in Cata. I may not bother to fix it.~
Walayimuna commented 4 months ago

And I can't use gathermate2 WotLK version, right ? For what I read here someone had to modify it's code, where can I find a compatible gathermate2 with beta?

ynazar1 commented 4 months ago

That is correct. The WotLK Gathermate2 doesn't have archaeology profession tracking.

You may be able to hack it in like @vtosh did or hack retail version to work with cata or wait for live. Since beta things don't really matter, I'd wait for live. I guess i'll be able to make sure that Arh works with whatever live gathermate2 version decides to do.

Walayimuna commented 4 months ago

It would be awesome to have a working version on the 30th, when prepatch goes live

ynazar1 commented 4 months ago

You should poke at Gathermate2 Classic to put arcaeology back for node support. I really-really do not feel like hacking around another Gathermate fork (similar to the DF treasures one i did last year when they refused to track random treasure chests in DF)

BjarkeM commented 4 months ago

AddOns.zip I've hacked together a fix for the gathermate2/gathermate2data addons to work with archaeology.

Most zones are mapped from the retail archaeology data to classic zones using IDs from this page: https://wowpedia.fandom.com/wiki/UiMapID

It's not 100% working (some zones are mapped incorrectly, but most of them are correct), but it's a start for anyone that wants the gathermate 2 nodes on this addon in classic. To test the functionality: Do this ingame EVERY TIME you reload/login and want to farm archaeology: /gathermate go to import tick archaeology click import GatherMate2Data

use Arh and the archaeology nodes will show up.

I didn't bother saving the points permanently, as it's not a complete fix - someone that cares enough can make a proper fix for gathermate2 classic :)

Straken33 commented 4 months ago

Edit: issue seems to be with my second wow account, as its working fine on the first one...

BjarkeM commented 4 months ago

works fine on cata prepatch for me :)

Walayimuna commented 4 months ago

I managed to hack together a working version of gathermate2. I can now see nodes appear, however innitially the nodes didn't rotate with the camera. Toggling rotate minimap manually, then reloading the UI allowed the nodes to rotate with the camera. I'm assuming however this is just a part of gathermate2 that i didn't manage to correctly hack together, and will be fixed when an official cata version is released

Can you please share your version of gathermate2, until there is official support for archaeology on the official gathermate2?

ynazar1 commented 4 months ago

The current Arh release works in Cata beta!!!

This Gathermate2 (zip below) should probably do till the official version comes out. This is based on latest classic. I didn't test all functionality but it's fairly sure to work in Cata. Likely not in Classic or SoD.

@vtosh found the bug why it doesn't rotate in classic. You can see it here. https://github.com/Nevcairiel/GatherMate2/issues/25 My zipped copy includes the fix.

I was able to import Archaeology data successfully from GM2_Data addon in the @BjarkeM 's folder and it retains between restarts.

GatherMate2.zip

ynazar1 commented 4 months ago

If anyone finds any new issues in latest release, please post here. Otherwise calling this complete

Litvan commented 4 months ago

If anyone finds any new issues in latest release, please post here. Otherwise calling this complete

the 2.0.6-126 from 13 hrs ago?

edit Seems to be working fine, with the above version of gathermate2 I even have the nice lil marker for where I dug up one image

ynazar1 commented 4 months ago

@Quinty31519 Arh doesn't 'normally' toggle unless you're on top of a digsite (see options about visibility). You can make it display by unchecking 'toggle with digsite' in options. I have no clue what superimposed map you mean.

For what it's worth battlefield minimap support has always been a bit wonky, i recommend to not use it if you can.... Here's my addons folder for Cata beta... There's absolutely no point to even bother with it in classic at the moment.

image

Quinty31519 commented 4 months ago

Edited original comment as I was referring to an older copy/release. Thanks @ynazar1 for clarifying! The post below/following this works in Cata Classic.

ynazar1 commented 4 months ago

@Quinty31519 Lol! You're on wrong addon! image You've got unfortunately ancient version that still floating around addon sites. Because it's all rights reserved I cannot upload mine there. :(

Grab the latest package from releases and delete the one you have. Also grab gathermate2 from this post for rotating nodes.

Quinty31519 commented 4 months ago

Huge! I did have an old version, and it works now! <3

ynazar1 commented 4 months ago

Update!

Official Classic Gathermate2 have put Archaeology back with the latest release. We're good to go for Cata Launch as far as I can tell.