search

ynkdir / py-win32more

Python bindings for Win32 API generated from win32metadata.
MIT License
112 stars 13 forks source link

Improve PointerHandler #8

Closed byehack closed 1 year ago

byehack commented 1 year ago

Partially _fixes https://github.com/ynkdir/py-win32more/issues/4#issuecomment-1468900076

ynkdir commented 1 year ago

Is this ready to merge?

byehack commented 1 year ago

Hi @ynkdir , before anything, I think the whole of PointerHandler won't be cover the most of functions. it just does great job for few of them. btw it is currently implemented, we should create a mapping python types and c-types that supported. for example, in this PR we could add another condition for support convert int to Int16, UInt16, Int64 and UInt64 too. maybe the better way is using a dictionary that these types correctly mapped.

ynkdir commented 1 year ago

I will commit some changes before you complete it. It supports assigning to structure member with type casting and it conflicts with this pull request.

byehack commented 1 year ago

https://github.com/ynkdir/py-win32more/commit/c723275857ab6d104aa6afed2e731132f9de9a74 seems reasonable. I didn't test yet but seems works. I'm going to close this PR as we don't need it anymore.