ynohtna92 / SheepTag

:sheep: Dota 2 Custom Map based on the original WC3 Map (Sheep Tag ReVo 7.7.4)
http://steamcommunity.com/sharedfiles/filedetails/?id=435131884
GNU General Public License v2.0
2 stars 2 forks source link

TODO #1

Open ynohtna92 opened 9 years ago

ynohtna92 commented 9 years ago

Critical things that need to be completed. Upon completing a job mention this issue in your commit as well as checking off the task below.

VincentK-ZA commented 4 years ago

Hi there @ynohtna92

I'm not at all experienced in custom games, but would like to make a small PR that allows using the shop regularly (i.e. right click to buy items). I think this broke somewhere along the line with some dota updates.

The simplest fix I could find was this:

GameRules:GetGameModeEntity():SetStashPurchasingDisabled(true)

to

GameRules:GetGameModeEntity():SetStashPurchasingDisabled(false)

Let me know how I can contribute the change here. If you do not have time or would prefer it, just let me know and I can create a fork and submit a new game if that is okay with you. But would prefer to update yours.

Thank you for the awesome game that still works 99% after all these years!

ynohtna92 commented 4 years ago

Hi @VincentK-ZA,

You should be able to create a branch, make the change and submit a pull request. I will approve it once I have confirmed it is all working.

VincentK-ZA commented 4 years ago

Thanks, but I don't have write access to the repository, so can't push my branch up.

This is the error I get when trying to push my branch up: image

ynohtna92 commented 4 years ago

Thanks, but I don't have write access to the repository, so can't push my branch up.

This is the error I get when trying to push my branch up: image

You will want to create a fork and do the change then make a pull request :).