ynop / audiomate

Python library for handling audio datasets.
https://audiomate.readthedocs.io/
MIT License
131 stars 26 forks source link

Show tatoeba process #112

Closed DanBmh closed 4 years ago

DanBmh commented 4 years ago

I also changed the label type, because this solved a problem i had and the other datasets seemed to have LL_WORD_TRANSCRIPT as default and LL_WORD_TRANSCRIPT_RAW only optionally.

DanBmh commented 4 years ago

Ok, i will move the LL_WORD_TRANSCRIPT commit to another branch. What about the updated comment, shall i make a third pull request for it?

Regarding the tqdm and print suggestions, you are using both in the other files, for example here, so i thought it would be ok to use them too.

aahlenst commented 4 years ago

In my opinion, you can do the comment together with LL_WORD_TRANSCRIPT.

Regarding tqdm/printing, I'm sorry that it hit you. Let's see what @ynop has to say.

ynop commented 4 years ago

I added those things when I needed it. But, @aahlenst is right, it is not a good solution. I guess we should find a better way to do it.

DanBmh commented 4 years ago

I would suggest then we merge this with tqdm and print and you find a better way some other time:)

aahlenst commented 4 years ago

@DanBmh #114 brought the necessary infrastructure for logging. Care to update your PR?

DanBmh commented 4 years ago

Do you plan to implement a prediction for the time to completion in your logger? I found this helpful in very long running tasks (>4h).

ynop commented 4 years ago

No plans so far. But would be easy to implement based on the 5 minute logging cycle and nice to have. If you'd like to do it, you can add it and open a PR.

ynop commented 4 years ago

Could you merge the two commits? Afterwards I can merge it.

DanBmh commented 4 years ago

Done. Why didn't you merge this before updating the logging?

ynop commented 4 years ago

Because, I didn't think about that before merging the logging. And it is cleaner instead of introducing more "bad examples" and correct it right again.