ynorth-projects / openy_repeat

Decouple openy_repeat.
1 stars 17 forks source link

DS-1100 Migrate schedules fix to main repo #37

Closed froboy closed 7 months ago

froboy commented 10 months ago

@podarok if you create a new branch, we can merge this into the source repo on a separate branch, then it's not as fragile a connection.

from https://github.com/seattleymca/openy_repeat/tree/YGSSLA-396

rollki commented 10 months ago

@froboy For one of the clients, we can observe a problem with duplicate categories in the left side.

image

Actuallyб the problem is wrong content management, as someone created 2 or more categories (activity CT) with the same title (one of which with an empty subcategory field) that's why the query returns 2 records with the same title, and later vuejs renders it and perceives it as one and the same, since the keys are different, but the values are the same.

Theoretically, the problem can be solved on the side of content management, but it is probably better to use distinct and prevent such cases.

I don't think we can solve both problems, as we can only solve the technical side.

Solution: $query->distinct(TRUE);

Screenshot 2023-12-20 at 15 08 27
rollki commented 10 months ago

@froboy If you agree with the decision, I propose to do it in this PR :) But we can discuss it of course

froboy commented 8 months ago

@rollki sorry I missed this. I've added that fix.

podarok commented 8 months ago

https://github.com/ynorth-projects/openy_repeat/tree/schedules_fix @froboy