search

ynorth-projects / openy_repeat

Decouple openy_repeat.
1 stars 17 forks source link

feature/add-filter-by-instructor|Added the filter by instructor for t… #47

Closed oleh-rymar closed 6 months ago

oleh-rymar commented 6 months ago

…he Repeat Schedules block.

oleh-rymar commented 6 months ago

@froboy Fixed. Please, check.

oleh-rymar commented 6 months ago

Testing:

  1. Go to the "Repeat Schedules" block/paragraph settings form.
  2. Select "by instructor name" in the Filters section. Screenshot from 2024-04-23 20-13-20
  3. Select "Display instructor".
  4. Save the "Layout Builder" changes/node changes.

  5. Screenshot from 2024-04-23 20-12-54 Screenshot from 2024-04-23 20-12-50 Screenshot from 2024-04-23 20-12-38

  6. We have an additional filter for the “Instructor” field.
podarok commented 6 months ago

I think height of the element in Dropdown is not correct We need to do better UX

image

oleh-rymar commented 6 months ago

Screenshot from 2024-04-25 10-16-46 @podarok @froboy Updated.

podarok commented 6 months ago

See https://yusaslackinstance.slack.com/archives/C03E6SQQ0Q5/p1714061856384559?thread_ts=1713557003.572269&cid=C03E6SQQ0Q5 @oleh-rymar

I'm merging this as it is functional BUt if we can do select list as dropdown menu from https://www.w3schools.com/css/css_dropdowns.asp - that would be great